Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable \includegraphics until trust settings is merged #1951

merged 3 commits into from Apr 28, 2019


Copy link

commented Apr 23, 2019

This is only temporary and I thought that simply disabling the this function would be easier that removing it and adding it back in later.


This comment has been minimized.

Copy link

commented Apr 23, 2019

Codecov Report

Merging #1951 into master will decrease coverage by 1.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
- Coverage   94.92%   93.18%   -1.74%     
  Files          79       79              
  Lines        4843     4843              
  Branches      845      845              
- Hits         4597     4513      -84     
- Misses        222      290      +68     
- Partials       24       40      +16
Flag Coverage Δ
#screenshotter 88.92% <ø> (-0.57%) ⬇️
#test 84.47% <ø> (-1.55%) ⬇️
Impacted Files Coverage Δ
src/functions.js 100% <ø> (ø) ⬆️
src/functions/includegraphics.js 0% <0%> (-94.21%) ⬇️
src/domTree.js 81.52% <0%> (-7.07%) ⬇️
src/Parser.js 95.37% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb312f...87a1843. Read the comment docs.


This comment has been minimized.

Copy link

commented Apr 23, 2019

For 0.10.1, we did a commit on the v0.10.1 release branch that reverted the change, without affecting master. I'm not sure which is better:

  1. Merge this with master so releasing is easier.
  2. Retarget this to v0.10.2 release branch.

I'm fine either way. The disabling looks good.


This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

@edemaine I forgot about us disabling \includegraphics once before. Merging this commit with master seems the best way to avoid confusion in the future.

@kevinbarabash kevinbarabash referenced this pull request Apr 28, 2019

@kevinbarabash kevinbarabash merged commit 5806b24 into master Apr 28, 2019

9 of 10 checks passed

Pages changed 3 new files uploaded
Header rules 2 header rules processed
Mixed content No mixed content detected
Redirect rules 5 redirect rules processed
Screenshotter - Chrome Screenshotter Passed
Screenshotter - Firefox Screenshotter Passed
ci/circleci: chrome Your tests passed on CircleCI!
ci/circleci: firefox Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
deploy/netlify Deploy preview ready!

@kevinbarabash kevinbarabash deleted the disable_includegraphics branch Apr 28, 2019

This was referenced Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.