Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump css-loader from 2.1.0 to 3.0.0 #2021

Merged
merged 1 commit into from Jul 13, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 9, 2019

Bumps css-loader from 2.1.0 to 3.0.0.

Release notes

Sourced from css-loader's releases.

v3.0.0

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option

v2.1.1

2.1.1 (2019-03-07)

Bug Fixes

  • do not break selector with escaping (#896) (0ba8c66)
  • source map generation when sourceRoot is present (#901) (e9ce745)
  • sourcemap generating when previous loader pass sourcemap as string (#905) (3797e4d)
Changelog

Sourced from css-loader's changelog.

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option

2.1.1 (2019-03-07)

Bug Fixes

  • do not break selector with escaping (#896) (0ba8c66)
  • source map generation when sourceRoot is present (#901) (e9ce745)
  • sourcemap generating when previous loader pass sourcemap as string (#905) (3797e4d)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@codecov-io
Copy link

codecov-io commented Jul 9, 2019

Codecov Report

Merging #2021 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2021   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files          79       79           
  Lines        4992     4992           
  Branches      876      876           
=======================================
  Hits         4660     4660           
  Misses        291      291           
  Partials       41       41
Flag Coverage Δ
#screenshotter 89.07% <ø> (ø) ⬆️
#test 86.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98164d...9ffbc64. Read the comment docs.

@kevinbarabash
Copy link
Member

How do people feel about accepting major version bump PRs from dependabot? The screenshot tests are passing so the CSS must be working, right?

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/css-loader-3.0.0 branch 3 times, most recently from 81c5f93 to 822141f Compare July 9, 2019 03:30
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/css-loader-3.0.0 branch from 822141f to 9ffbc64 Compare July 13, 2019 23:29
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbarabash kevinbarabash merged commit 89042d8 into master Jul 13, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/css-loader-3.0.0 branch July 13, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants