Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend useRect to update for specified event #41

Conversation

@glie163
Copy link
Contributor

commented Aug 12, 2019

useRect is a custom hook for reading the bounding rect of an element
We are using the bounding rect of a component to resize an svg within it
The rect was only updating on window resize and scroll events, we needed our component to update and resize after css transitions on the page
This PR extends useRect() so we can specify events like "transitionend" to trigger and update

@nhardy

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Looks good to me. Not sure if I have permission to approve a PR.

@nhardy

nhardy approved these changes Aug 13, 2019

@ojkelly ojkelly merged commit a6acb6a into master Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.