Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed eslint-plugin config #63

Merged
merged 2 commits into from Mar 12, 2020
Merged

Fixed eslint-plugin config #63

merged 2 commits into from Mar 12, 2020

Conversation

@ojkelly
Copy link
Member

ojkelly commented Mar 12, 2020

The recommended config was wrong, the values were the wrong way around.

This works now.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Mar 12, 2020

Coverage Status

Coverage increased (+0.7%) to 91.76% when pulling 965ea23 on ok/fix-eslint-plugin into ea6d240 on master.

packages/eslint-plugin/src/index.js Outdated Show resolved Hide resolved
Co-Authored-By: Nathan Hardy <nhardy@users.noreply.github.com>
@nhardy
nhardy approved these changes Mar 12, 2020
@ojkelly ojkelly merged commit 3bd2884 into master Mar 12, 2020
4 checks passed
4 checks passed
build (8.x)
Details
build (10.x)
Details
build (12.x)
Details
coverage/coveralls Coverage increased (+0.7%) to 91.76%
Details
@ojkelly ojkelly deleted the ok/fix-eslint-plugin branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.