Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fails (with older Mojolicious?) #2

Open
eserte opened this issue Jun 25, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@eserte
Copy link

commented Jun 25, 2019

On a few of my smoker systems the test suite fails:

#   Failed test '[03_untrusted_source.3] Assert from header X-Real-IP => 1.1.1.1 that tx->remote_address == 127.0.0.1 (unchanged)'
#   at t/03_untrusted_source.t line 38.
#          got: '1.1.1.1'
#     expected: '127.0.0.1'

#   Failed test '[03_untrusted_source.4] Assert from header X-SSL => 1 that req->is_secure == false (unchanged)'
#   at t/03_untrusted_source.t line 47.
#          got: 'https'
#     expected: 'http'
# Looks like you failed 2 tests of 12.
t/03_untrusted_source.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/12 subtests 
... (etc) ...

This seems to happen if Mojolicious is too old. Statistical analysis (theta=0 means "failure"):

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name           	       Theta	      StdErr	 T-stat
[0='const']    	     -0.0000	      0.0000	  -5.56
[1='eq_6.64']  	      0.0000	      0.0000	   0.56
[2='eq_7.05']  	     -0.0000	      0.0000	  -2.06
[3='eq_7.18']  	      0.0000	      0.0000	   2.25
[4='eq_7.33']  	      1.0000	      0.0000	5838671899791342.00
[5='eq_7.58']  	      1.0000	      0.0000	5056438189581652.00
[6='eq_8.05']  	      1.0000	      0.0000	5056438189581652.00
[7='eq_8.09']  	      1.0000	      0.0000	5056438189581653.00
[8='eq_8.11']  	      1.0000	      0.0000	5056438189581653.00
[9='eq_8.12']  	      1.0000	      0.0000	5056438189581652.00
[10='eq_8.14'] 	      1.0000	      0.0000	6527833633125640.00
[11='eq_8.15'] 	      1.0000	      0.0000	6620431643035254.00
[12='eq_8.17'] 	      1.0000	      0.0000	7044938593841565.00

R^2= 1.000, N= 57, K= 13
****************************************************************
@Kage

This comment has been minimized.

Copy link
Owner

commented Jun 25, 2019

Hi @eserte , thanks for the report! I assume those are Mojolicious versions 7.18, 7.05, and 6.64 in your tests? I'm unsure if "const" is also supposed to represent some version, but I'll look into those versions of Mojo 7 and 6 and see if I can find the cause.

@Kage Kage added the bug label Jun 25, 2019

@Kage Kage self-assigned this Jun 25, 2019

@eserte

This comment has been minimized.

Copy link
Author

commented Jun 25, 2019

Yes, with 7.18 and older it fails, and with 7.33 and newer it passes. You may disregard "const".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.