New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If in PageName is quotes (") used . Page Tree iş not working #81

Closed
barisakpunar opened this Issue Jan 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@barisakpunar

If quotes (") is used in PageName attribute, PageTreeControl in Admin Page is not working. Because when feeding the tree, PageName attributes is used for converting to Json. And quotes (") is breaking the hierarchy of Json. We should validate this before publishing.

@fschultz fschultz added the bug label Jan 8, 2016

@fschultz fschultz added this to the Release 1.1.1 milestone Jan 8, 2016

@fschultz fschultz self-assigned this Jan 8, 2016

@fschultz

This comment has been minimized.

Show comment
Hide comment
@fschultz

fschultz Jan 8, 2016

Contributor

Thanks! I've switched the code that feeds the tree with items to use the same JSON serialization as the rest of the system uses. This should handle all JSON incompability. I've also fixed an issue where the quotes also caused a JavaScript error.

Contributor

fschultz commented Jan 8, 2016

Thanks! I've switched the code that feeds the tree with items to use the same JSON serialization as the rest of the system uses. This should handle all JSON incompability. I've also fixed an issue where the quotes also caused a JavaScript error.

@fschultz

This comment has been minimized.

Show comment
Hide comment
@fschultz

fschultz Jan 9, 2016

Contributor

I've uploaded a package of version 1.1.1-beta to nuget.org that should be able to handle quotes in the page tree.

Contributor

fschultz commented Jan 9, 2016

I've uploaded a package of version 1.1.1-beta to nuget.org that should be able to handle quotes in the page tree.

@fschultz fschultz added the done label Jan 15, 2016

@fschultz

This comment has been minimized.

Show comment
Hide comment
@fschultz

fschultz Jan 20, 2016

Contributor

Version 1.1.1 just released should fix this issue.

Contributor

fschultz commented Jan 20, 2016

Version 1.1.1 just released should fix this issue.

@fschultz fschultz closed this Apr 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment