New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HtmlHelperExtensions.cs to include useful URL generation methods #130

Merged
merged 2 commits into from Dec 9, 2017

Conversation

Projects
None yet
2 participants
@Matthew-Bonner
Contributor

Matthew-Bonner commented Aug 21, 2017

As the URL's that come from the CMS are not routes, I find it easier to define two methods to help generate URL's to CMS pages so that I don't have to hard code them. The two methods posted help resolve this issue. Do we need to set up any examples of how to use these methods so that others are aware that they exist?

Matthew-Bonner added some commits Aug 21, 2017

Update HtmlHelperExtensions.cs to include useful URL generation methods
As the URL's that come from the CMS are not routes, I find it easier to define two methods to help generate URL's to CMS pages so that I don't have to hard code them. The two methods posted help resolve this issue. Do we need to set up any examples of how to use these methods so that others are aware that they exist?
Update HtmlHelperExtensions.cs
Added missing namespaces
@fschultz

This comment has been minimized.

Show comment
Hide comment
@fschultz

fschultz Aug 21, 2017

Contributor

Thanks! I've manually merged the branch of your pull request into the 1.2.3-dev branch, and if everything works as it should this will be reflected in the pull request once the 1.2.3-dev branch is merged into master when it goes live.

It's a good idea to show how these extensions can be used and I'll add it to the release notes. I'm also working on updating the code base of kaliko.com, once done I'll start adding documentation to the knowledge area and will include this also.

Contributor

fschultz commented Aug 21, 2017

Thanks! I've manually merged the branch of your pull request into the 1.2.3-dev branch, and if everything works as it should this will be reflected in the pull request once the 1.2.3-dev branch is merged into master when it goes live.

It's a good idea to show how these extensions can be used and I'll add it to the release notes. I'm also working on updating the code base of kaliko.com, once done I'll start adding documentation to the knowledge area and will include this also.

@fschultz fschultz added this to the Release 1.2.3 milestone Aug 21, 2017

@fschultz fschultz self-assigned this Aug 21, 2017

@fschultz fschultz merged commit 7cc5157 into KalikoCMS:master Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment