[PC-168] Challenge tips disappear if challenge already complete #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a challenge has been already complete go to the next one
delete all console.log
tombettany
requested changes
Jun 4, 2019
lib/controller/challenge.js
Outdated
| $scope.hint = $scope.content.steps[step] ? $scope.content.steps[step].hint : null; | ||
| } | ||
| $scope.solution = $scope.getSolution(); |
There was a problem hiding this comment.
Presumably we don't need to update the solution either if we've reached the end of the steps.
lib/controller/challenge.js
Outdated
| $scope.next = getNextChallenge(); | ||
|
|
||
| setStep(0); | ||
| $scope.started = true; | ||
| $scope.animationClass = ''; | ||
|
|
||
| $scope.$watch('step', function (step) { | ||
| if (step >= $scope.content.steps.length) { | ||
| //$scope.completed = true; |
lib/controller/challenge.js
Outdated
| if (step >= $scope.content.steps.length) { | ||
| //$scope.completed = true; | ||
| $scope.validate() | ||
| } else { | ||
| $scope.hint = $scope.content.steps[step] ? $scope.content.steps[step].hint : null; |
lib/controller/challenge.js
Outdated
| @@ -443,7 +448,6 @@ app.controller('ChallengeController', function ($scope, $routeParams, $window, $ | |||
| xpMessage = xpGain ? ' You earned ' + $scope.xpGain + 'xp!' : '', | |||
| onlineMessage = successMsg, | |||
| offlineMessage = onlineMessage + xpMessage; | |||
|
|
|||
lib/controller/challenge.js
Outdated
| $scope.next = getNextChallenge(); | ||
|
|
||
| setStep(0); | ||
| $scope.started = true; | ||
| $scope.animationClass = ''; | ||
|
|
||
| $scope.$watch('step', function (step) { | ||
| if (step >= $scope.content.steps.length) { |
There was a problem hiding this comment.
Presumably getting the validation to trigger on things other than key press didn't pan out?
tombettany
changed the title
tombettany
requested changes
Jun 7, 2019
There was a problem hiding this comment.
Wait, now we are doing both? I thought that the two options were either:
- Add if in the
$watchonsteptovalidate()if you are at the end - Remove the
session.stepscriterion from theif()statement invalidate()
The plan was definitely not to do both. Remove the former and make sure that it is working with these changes.
old solution
I agree with you, probably I when I checkout all the file to delete the console I didn't realise the format version had the previous solution. It now should be done. |
tombettany
approved these changes
Jun 11, 2019
tombettany
deleted the
PC-168/ChallengeTips-disappear-if-challengeAlreadyComplete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will allow the challenge to go to the next one if it has been already complete