Conversation
This was
linked to
issues
Sep 28, 2023
jepeteo
commented
Oct 1, 2023
Contributor
Author
There was a problem hiding this comment.
- changed directory and files structure
- loaded the tailwindcss the correct way (through npm)
- refactored actor cards (added skeleton loading to actor images)
- added some more styles through tailwind
- added some documentation
- the search now handles no results and show the appropriate message
Member
|
Can you please guide me through the installation process so I can test that the code works? I checked out the-purge branch, added a new public/js/the_config.js file from the template and filled in the API key. |
Member
|
ok, it works. it just needed to run the files from a web server. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleared the old code, removed phonegap, glyphicons bootstrap.
Move the project to root folder.
Created config file in the js directory to use for api key and other sensitive information.
Created example config file.
Redeisign the project from scratch with Tailwind CSS.
Added deathdate, birthday and image to the results.
Used Heroricons as svg for performance.