Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ns-3 docset. #1096

Merged
merged 10 commits into from
Sep 26, 2016
Merged

Added ns-3 docset. #1096

merged 10 commits into from
Sep 26, 2016

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 25, 2016

I added a docset for the ns-3 network simulator.
However, the ns-3.tgz is around 2.5 GB, so I'd need somewhere to upload it before the PR can be accepted.

Regards!

@tnull
Copy link
Contributor Author

tnull commented Sep 25, 2016

I uploaded the ns-3.tgz, you can pull it from: https://tnull.de/static/ns-3.tgz

@Kapeli
Copy link
Owner

Kapeli commented Sep 25, 2016

2.5 GB is a bit too large unfortunately. Any idea what's causing the size? The docset has around 2400 classes, so it shouldn't be quite that large.

@tnull
Copy link
Contributor Author

tnull commented Sep 26, 2016

I think the size comes mostly from huge number of png files. These should be inheritance graphs and collaboration diagrams generated by doxygen/dot. Should I exclude them? Then, however, the documentary might be broken at some points (as in you would see that there is something missing).

@Kapeli
Copy link
Owner

Kapeli commented Sep 26, 2016

Maybe configure Doxygen so it doesn't generate graphs at all?

@tnull
Copy link
Contributor Author

tnull commented Sep 26, 2016

Yep, I disabled some variables (but I think setting HAVE_DOT = NO should be enough) and was able to push the file size of ns-3.tgz to 72 megabytes. See the updated commits! :)

@Kapeli
Copy link
Owner

Kapeli commented Sep 26, 2016

Great. Please fix these issues though:

Not 16x16: "icon.png" in "ns-3"
Not 32x32: "icon@2x.png" in "ns-3"

@tnull
Copy link
Contributor Author

tnull commented Sep 26, 2016

Done. Strange, each of the icons were exactly twice as large. Must have done sth. wrong while saving them.

@Kapeli Kapeli merged commit 2fca3bd into Kapeli:master Sep 26, 2016
@Kapeli
Copy link
Owner

Kapeli commented Sep 26, 2016

Thank you! 👍

Kapeli added a commit that referenced this pull request Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants