Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability improvements #12

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@GregoryMaks
Copy link

commented Nov 15, 2016

The code would look a bit prettier with these improvements. Though I know that this is not enough for the full picture, every little bit helps. Feel free to criticize.

Please verify that the changes are correct, I did it twice, but still it's a bit scary.

@Kapeli

This comment has been minimized.

Copy link
Owner

commented Nov 16, 2016

I can't currently allocate time to review pull requests that improve readability/refactor things. I'm going to mention in the contribution guidelines that I'm only accepting bug fixes and/or new features.

Sorry!

@Kapeli Kapeli closed this Nov 16, 2016

@jrappen

This comment has been minimized.

Copy link

commented Nov 17, 2016

FYI @Kapeli on Github you can usually drop whitespace changes by appending ?w=1 to any URL where there is a commit or a diff which makes things easier to review. Compare the difference for the files changed tab for this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.