Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.6.x #89

Closed
KarelCemus opened this issue May 28, 2017 · 9 comments
Closed

Play 2.6.x #89

KarelCemus opened this issue May 28, 2017 · 9 comments
Labels
Milestone

Comments

@KarelCemus
Copy link
Owner

Update to Play 2.6.x, more specifically support its new cacheApi module introducing sync and async API.

@KarelCemus KarelCemus added this to the 1.5.0 milestone May 28, 2017
@scozv
Copy link

scozv commented Jun 14, 2017

@KarelCemus

Hi, may I know when will you plan to release 1.5.0 for Play 2.6 and Scala 2.12 ?

Thanks

@KarelCemus
Copy link
Owner Author

Hi, well, it is prepared as a snapshot and it should work, so feel free to test it.

However, there are several internal issues I want to resolve before the stable release but as I am a bit short on time right now, I am considering releasing a milestone or postponing the refactoring for a subsequent release. Either way, I need some feedback that it is actually working with Play 2.6 before I publish a stable release. I haven't used it yet myself.

@KarelCemus
Copy link
Owner Author

@scozv Are you willing to test it actually works with Play 2.6? It would be much help, I'd appreciate. Basically, I am worried only about the configuration, otherwise, it should be alright.

@scozv
Copy link

scozv commented Jun 14, 2017

Yes, I am willing to test it on Play 2.6 and Scala 2.12.

Currently, I just put the your master dependency in my build.sbt (see below).

Before Play 2.6, I am using the com.typesafe.play.plugins %% play-plugins-redis for Play 2.3.

So I need some time to upgrade my source code, and test the play-redis on Play 2.6.

I will let you know, if I have any further questions. Thanks.

lazy val playRedis = RootProject(uri("git://github.com/KarelCemus/play-redis"))

lazy val root = (project in file("."))
  .enablePlugins(PlayScala)
  .dependsOn(playRedis)

@KarelCemus
Copy link
Owner Author

Great, thanks! Don't forget to enable Sonatype snapshots resolver, might be necessary. Keep me posted, if anything, feel free to ask.

@KarelCemus
Copy link
Owner Author

KarelCemus commented Jun 14, 2017

Well, looking at your configuration, you make it too complicated. Just add this and you should be fine

libraryDependencies += play.sbt.PlayImport.cacheApi
// include play-redis library
libraryDependencies += "com.github.karelcemus" %% "play-redis" % "1.5.0-SNAPSHOT"

resolvers +=Resolver.sonatypeRepo( "snapshots" )

After the release, you'd just remove the -SNAPSHOT part

@scozv
Copy link

scozv commented Jun 14, 2017

Thank, but in your master, your version is 1.4.2-SNAPSHOT right now. :)

https://oss.sonatype.org/content/repositories/public/com/github/karelcemus/play-redis_2.12/

1.4.2-SNAPSHOT/	Mon Jun 12 03:58:36 UTC 2017	 	

I can use 1.4.2-SNAPSHOT at first.

@KarelCemus
Copy link
Owner Author

My bad, I forgot to update the version.sbt. Travis is already building 1.5.0-SNAPSHOT. Thanks!

@KarelCemus
Copy link
Owner Author

@scozv Please let's move to #95, this issue was about migrating the code to Play 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants