MGET, MSET and MSETNX commands #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed public mGet and mSet to better fit cache purposes - fixed code style - implemented MSETNX - updated readme
|
Thanks for quick response. I fully see your points. Overloading with Map() might be necessary for the future, but you'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80, fixes #81
Implements #80 using #81 - just refactored, fixed several issues plus added SETNX and updated readme
@pcejrowski Thanks for your PR. Great job! I admire you understood my code. Well done! Could you look at this? I used your PR and just refactored it plus made several improvements. The major change comparing to your PR is that I renamed the methods in CacheAPI and changed their signature. It seems to me that this fits better the CacheAPI intention. CacheAPI should be independent on commands thus I don't like MGET and MSET names and I like varargs signature and want to be consistent with the rest of the API. But if it turns out that the using the Map is a frequent scenario, I will overload the method.