Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

[SoftEA] Add missing setting for Sink reopen

  • Loading branch information...
1 parent 5659d71 commit dee978624a77822918417070bcd7e5c87db1ff91 @Karlson2k committed
Showing with 3 additions and 0 deletions.
  1. +3 −0  xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
3  xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
@@ -521,6 +521,9 @@ void CSoftAE::OnSettingsChange(std::string setting)
setting == "audiooutput.mode" ||
setting == "audiooutput.ac3passthrough" ||
setting == "audiooutput.dtspassthrough" ||
+ setting == "audiooutput.passthroughaac" ||
da-anda added a note

why "passthroughaac" instead of "aacpassthrough" which would be in sync with the rest?

@Karlson2k Owner

For historical reasons.

yeah - should be uniform - better as "aacpassthrough"

@Karlson2k Owner

@DDDamian so it should be changed everywhere in code.
It will be separate PR.
May be it's better so use template "audiooutput.passthrough???"?

Sure - it's just for consistency, and it's a minor detail. Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ setting == "audiooutput.truehdpassthrough" ||
+ setting == "audiooutput.dtshdpassthrough" ||
setting == "audiooutput.channellayout" ||
setting == "audiooutput.useexclusivemode" ||
setting == "audiooutput.multichannellpcm" ||

0 comments on commit dee9786

Please sign in to comment.
Something went wrong with that request. Please try again.