Permalink
Browse files

[SoftEA] Add missing setting for Sink reopen

  • Loading branch information...
1 parent 5659d71 commit dee978624a77822918417070bcd7e5c87db1ff91 @Karlson2k committed Oct 18, 2012
Showing with 3 additions and 0 deletions.
  1. +3 −0 xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
@@ -521,6 +521,9 @@ void CSoftAE::OnSettingsChange(std::string setting)
setting == "audiooutput.mode" ||
setting == "audiooutput.ac3passthrough" ||
setting == "audiooutput.dtspassthrough" ||
+ setting == "audiooutput.passthroughaac" ||
da-anda
da-anda Oct 18, 2012

why "passthroughaac" instead of "aacpassthrough" which would be in sync with the rest?

Karlson2k
Karlson2k Oct 18, 2012 Owner

For historical reasons.

DDDamian
DDDamian Oct 18, 2012

yeah - should be uniform - better as "aacpassthrough"

Karlson2k
Karlson2k Oct 19, 2012 Owner

@DDDamian so it should be changed everywhere in code.
It will be separate PR.
May be it's better so use template "audiooutput.passthrough???"?

DDDamian
DDDamian Oct 19, 2012

Sure - it's just for consistency, and it's a minor detail. Nice catch.

+ setting == "audiooutput.truehdpassthrough" ||
+ setting == "audiooutput.dtshdpassthrough" ||
setting == "audiooutput.channellayout" ||
setting == "audiooutput.useexclusivemode" ||
setting == "audiooutput.multichannellpcm" ||

0 comments on commit dee9786

Please sign in to comment.