Browse files

XBMCTinyXML: remove old workaround

  • Loading branch information...
1 parent f9bbb34 commit ad8491320790945298c85d13d7d6269d28fd8003 @Karlson2k committed May 12, 2013
Showing with 1 addition and 9 deletions.
  1. +1 −9 xbmc/utils/XBMCTinyXML.cpp
View
10 xbmc/utils/XBMCTinyXML.cpp
@@ -53,15 +53,7 @@ bool CXBMCTinyXML::LoadFile(const char *_filename, TiXmlEncoding encoding)
bool CXBMCTinyXML::LoadFile(const CStdString &_filename, TiXmlEncoding encoding)
{
- // There was a really terrifying little bug here. The code:
- // value = filename
- // in the STL case, cause the assignment method of the std::string to
- // be called. What is strange, is that the std::string had the same
- // address as it's c_str() method, and so bad things happen. Looks
- // like a bug in the Microsoft STL implementation.
- // Add an extra string to avoid the crash.
- CStdString filename(_filename);
- value = filename;
+ value = _filename.c_str();
void * buffPtr;
unsigned int buffSize = CFileUtils::LoadFile(value, buffPtr);

0 comments on commit ad84913

Please sign in to comment.