New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move `get_species_and_compartment_from_name` to wc_lang.Species #45

Closed

jonrkarr opened this issue Jan 18, 2019 · 1 comment

Assignees

Labels

Milestone

Initial dev issue...

Member

jonrkarr commented Jan 18, 2019 •

edited

Also redundant with ModelUtilities.parse_species_id

The text was updated successfully, but these errors were encountered:

jonrkarr added the refactor label

jonrkarr assigned jonrkarr and artgoldberg

Member Author

jonrkarr commented Jan 20, 2019 •

edited

Done

Added parse_id method to wc_lang.core.Species

Todo

Remove wc_sim.multialgorithm.utils.get_species_and_compartment_from_name
Remove wc_sim.multialgorithm.ModelUtilities.parse_species_id
Map calls of above functions to wc_lang.core.Species.parse_id

artgoldberg added this to the Initial dev issues for wc_sim in summer '19 milestone

artgoldberg closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment