Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelapse folders aren't discovered by the TimeLapseModel #2

Closed
llewelld opened this issue Sep 6, 2022 · 4 comments
Closed

Timelapse folders aren't discovered by the TimeLapseModel #2

llewelld opened this issue Sep 6, 2022 · 4 comments

Comments

@llewelld
Copy link
Contributor

llewelld commented Sep 6, 2022

Directories containing time lapse images are stored at ~/Pictures/.timelapse/<dd>/<MM>/<yyyy hh:mm> but as far as I can tell the model only checks for directories of the form ~/Pictures/.timelapse/<dir>, independent of whether they contain images or not.

Consequently it picks up only empty directories for which the Assembly step fails.

@llewelld
Copy link
Contributor Author

llewelld commented Sep 6, 2022

PR #3 is an attempt to fix this. It searches recursively through the subdirectories and only registers those containing images with .jpg or .jpeg extensions.

@Karry
Copy link
Owner

Karry commented Sep 10, 2022

Ups. It seems that using locale specific date-time format for timelapse name was not the greatest idea ever. Timelapse name should not contains slash at the first place.

Thank you for reporting this issue! I will look on your proposal during weekend.

@llewelld
Copy link
Contributor Author

I hadn't realised that the extra directory separators in the name were unintentional, but now you mention it it makes perfect sense. I've updated the PR to use a time format without these forward slashes, which I'm guessing is closer to what you want.

@Karry
Copy link
Owner

Karry commented Sep 16, 2022

Thank you for report. It will be solved by #7 . I decided to rework the list of timelapses a bit.

@Karry Karry closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants