Fix ingester not exiting automatically #80
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the ingester Docker container exits automatically upon completion by modifying the script's exit behavior and updating compose commands.
The ingester script previously did not explicitly call
process.exit()and lacked robust error handling for resource cleanup, leading to the container hanging. This PR adds afinallyblock to ensurevectorStore.close()is called andprocess.exit()is invoked with the correct status code, along with documenting the necessarydocker composeflags for proper container termination. Additionally, the embedding model selection now gracefully falls back from Gemini to OpenAI if one is unavailable.