Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages for BFS validation #313

Merged
merged 1 commit into from Jun 19, 2021

Conversation

ddn0
Copy link
Contributor

@ddn0 ddn0 commented Jun 19, 2021

No description provided.

@ddn0 ddn0 requested a review from nicelhc13 June 19, 2021 03:13
Copy link
Contributor

@nicelhc13 nicelhc13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@arthurp
Copy link
Contributor

arthurp commented Jun 19, 2021

I feel this might be some evidence for banning bare error codes entirely. I think it might be a good idea. This is far from the first time I've seen this issue.

@ddn0 ddn0 merged commit 449f78b into KatanaGraph:master Jun 19, 2021
@ddn0 ddn0 deleted the feature/add-assert-messages branch June 19, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants