From 798bb3cb1f1fe957f9bafcabcb43b05c74fc5c20 Mon Sep 17 00:00:00 2001
From: "Kate.Friedman" <Kate.Friedman@noaa.gov>
Date: Tue, 27 Feb 2024 13:35:39 +0000
Subject: [PATCH] Replace IODAPARM with gdas parm subfolder

- Delete IODAPARM variable from configs and scripts.
- Replace with path to PARMgfs/gdas/bufr2ioda.
- Add GDASApp parm to link script.

Refs #2332
---
 jobs/JGLOBAL_ATM_PREP_IODA_OBS        | 2 +-
 parm/config/gfs/config.prepatmiodaobs | 3 ---
 sorc/link_workflow.sh                 | 8 ++++++++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/jobs/JGLOBAL_ATM_PREP_IODA_OBS b/jobs/JGLOBAL_ATM_PREP_IODA_OBS
index ef0e682468..3eee24803a 100755
--- a/jobs/JGLOBAL_ATM_PREP_IODA_OBS
+++ b/jobs/JGLOBAL_ATM_PREP_IODA_OBS
@@ -18,7 +18,7 @@ YMD=${PDY} HH=${cyc} generate_com -rx COM_OBS
 ###############################################################
 # Run relevant script
 EXSCRIPT=${BUFR2IODASH:-${HOMEgfs}/ush/run_bufr2ioda.py}
-${EXSCRIPT} "${PDY}${cyc}" "${RUN}" "${DMPDIR}" "${IODAPARM}" "${COM_OBS}/"
+${EXSCRIPT} "${PDY}${cyc}" "${RUN}" "${DMPDIR}" "${PARMgfs}/gdas/bufr2ioda" "${COM_OBS}/"
 status=$?
 [[ ${status} -ne 0 ]] && (echo "FATAL ERROR: Error executing ${EXSCRIPT}, ABORT!"; exit "${status}")
 
diff --git a/parm/config/gfs/config.prepatmiodaobs b/parm/config/gfs/config.prepatmiodaobs
index ed9b246120..e29cf67b07 100644
--- a/parm/config/gfs/config.prepatmiodaobs
+++ b/parm/config/gfs/config.prepatmiodaobs
@@ -8,7 +8,4 @@ echo "BEGIN: config.prepatmiodaobs"
 # Get task specific resources
 . "${EXPDIR}/config.resources" prepatmiodaobs
 
-export BUFR2IODASH="${HOMEgfs}/ush/run_bufr2ioda.py"
-export IODAPARM="${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda"
-
 echo "END: config.prepatmiodaobs"
diff --git a/sorc/link_workflow.sh b/sorc/link_workflow.sh
index 3e0ff4db64..bbb889c294 100755
--- a/sorc/link_workflow.sh
+++ b/sorc/link_workflow.sh
@@ -199,6 +199,14 @@ if [[ -d "${HOMEgfs}/sorc/gdas.cd" ]]; then
   done
 fi
 
+#------------------------------
+#--add GDASApp parm directory
+#------------------------------
+if [[ -d "${HOMEgfs}/sorc/gdas.cd" ]]; then
+  cd "${HOMEgfs}/parm/gdas" || exit 1
+  ${LINK_OR_COPY} "${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda" .
+fi
+
 #------------------------------
 #--add GDASApp files
 #------------------------------