New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #27187 - Fixing Content View version Export for default organiz… #656
Conversation
|
Issues: #27187 |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
|
stumbled upon https://projects.theforeman.org/issues/26952 and learned that exporting the default organization view is unsupported and should be disallowed to prevent user confusion in the future. In that case, the provided PR becomes invalid. |
|
@vision2910 it is on the backlog, we need to get it done at some point, so right now we just want to error out until we get the code added. The issue is open for taking :) Otherwise, I will get to when I get some time. I will test this and see if it works the way we want to and reply back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine - what do you think about adding a test for this case?
|
raised a PR for https://projects.theforeman.org/issues/26952. @chris1984 @akofink sounds like a good idea for testing this PR's functionality. I will add a test for this case. |
|
I tested this, works fine, exported the default org view without issues. |
|
Thanks @vision2910 |
|
Thanks @mccun934, @chris1984, @akofink |
|
Merged without tests? :( 🙈 |
|
I will make another pr with updated tests me-- :( |
added the test #659 |
Fixed the content-view version export for default organization view by putting a check to ensure no nil library instance for the repository is passed through while checking the repo download policy.