Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #27213 - Add description to filter list #658

Merged
merged 1 commit into from Jul 3, 2019
Merged

Refs #27213 - Add description to filter list #658

merged 1 commit into from Jul 3, 2019

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Jul 2, 2019 •
edited

Will be submitting a 2nd pr unrelated to this one to start adding tests for the filter commands

----------|-------|-------------|------|----------
FILTER ID | NAME  | DESCRIPTION | TYPE | INCLUSION
----------|-------|-------------|------|----------
1         | nofox | pizza       | rpm  |          
----------|-------|-------------|------|----------

@theforeman-bot
Copy link

Issues: #27213

akofink
akofink approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@akofink akofink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK!

@akofink
Copy link
Member

akofink commented Jul 3, 2019

This needs a rebase

@chris1984 chris1984 merged commit 4283740 into Katello:master Jul 3, 2019
@chris1984 chris1984 deleted the update-filter branch July 3, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akofink akofink akofink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chris1984 @theforeman-bot @akofink