Fixes #32868 - Make --unlimited-hosts a flag so it doesn't require a value

[jeremylenz]

Previously:

hammer activation-key create:

• takes unlimited-hosts argument
• errors if you pass a value such as --unlimited-hosts=yes
• Behaves correctly.

hammer host-collection create:

• takes unlimited-hosts argument
• errors if you do NOT pass a value
• Behaves incorrectly.

With this patch, hammer host-collection create now takes --unlimited-hosts as a flag rather than a parameter, meaning that it behaves the same way as hammer activation-key create. Thus, hammer's behavior is more consistent.

[theforeman-bot]

Issues: #32868

[jeremylenz]

behavior before patch:

[vagrant@centos7-katello-devel hammer-cli-katello]$ hammer host-collection create --unlimited-hosts
Could not create the host collection:
  Error: Option '--unlimited-hosts': Value must be one of true/false, yes/no, 1/0..
  
  See: 'hammer host-collection create --help'.
[vagrant@centos7-katello-devel hammer-cli-katello]$ hammer activation-key create --unlimited-hosts=yes
Could not create the activation key:
  Error: Too many arguments.
  
  See: 'hammer activation-key create --help'.

[parthaa]

Mostly works well other than that one comment

[jeremylenz]

@parthaa committed your suggestion. It's on the dev box I had to destroy, so I didn't test it. But based on the same code in activation_keys I think it's fine :)

[parthaa]

@parthaa committed your suggestion. It's on the dev box I had to destroy, so I didn't test it. But based on the same code in activation_keys I think it's fine :)

works well

$ hammer  host-collection create --organization-id=1 --unlimited-hosts --name=great3 --max-hosts=1
Could not create the host collection:
  Error: You can't set all options --unlimited-hosts, --max-hosts at one time.
  
  See: 'hammer host-collection create --help'.