This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
refs #17201 - add rspec tests for migrations #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
suggested changes
Nov 4, 2016
| end | ||
|
|
||
| after(:each) do | ||
| `git reset HEAD --hard` |
There was a problem hiding this comment.
This may surprise developers who run tests. Maybe assert git status --short config/ is empty?
There was a problem hiding this comment.
Hm, good point. I'll just fix it so the test migrations don't dump their answers back into the git repo, which is the only reason I have the reset.
stbenjam
force-pushed
the
rspec
branch
3 times, most recently
from
0ba1957
to
347b076
Compare
|
@ekohl Updated |
ekohl
approved these changes
Nov 4, 2016
| let(:migrator) { Kafo::Migrations.new(scenario[:migrations]).run(scenario[:config].dup, scenario[:answers].dup) } | ||
|
|
||
| it 'does not change scenario config' do | ||
| after, _ = migrator |
|
Thanks! |
|
Thanks! This also adds tests to all our migrations which I believe we didn't have at first. That's a cool addition. |
|
Indeed, maybe it's useful to foreman-installer? theforeman/foreman-installer#208 |
zjhuntin
pushed a commit
to zjhuntin/katello-installer
that referenced
this pull request
Oct 30, 2018
Refs #12556 - fix content host reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.