Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Katello 3.5 and cockpit #570

Closed
wants to merge 4 commits into from
Closed

Katello 3.5 and cockpit #570

wants to merge 4 commits into from

Conversation

peppos
Copy link

@peppos peppos commented Dec 4, 2017

Change default port ssl from 9090 to 9093 because is not compatible with cockpit
theforeman/foreman_cockpit#14

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 0edbce0 must be in the format fixes #redmine_number - brief description
  • commit message for 0edbce0 is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 0edbce0 must be in the format fixes #redmine_number - brief description
  • commit message for 0edbce0 is not wrapped at 72nd column
  • e138b89 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@ekohl
Copy link
Member

ekohl commented Dec 4, 2017

Technically this would also need a migration but before we get into the technical details, it's good to think about the longer term goal.

Vanilla foreman uses port 8443 but in the katello context RHSM also uses 8443. That means we have a conflict. I recall @stbenjam was working on adding a proxy for the RHSM stuff so it could run on 8443 again. I'd prefer that over port 9093 but it'd need some work.

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 0edbce0 must be in the format fixes #redmine_number - brief description
  • commit message for 0edbce0 is not wrapped at 72nd column
  • e138b89 must be in the format fixes #redmine_number - brief description
  • a0d1902 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 0edbce0 must be in the format fixes #redmine_number - brief description
  • commit message for 0edbce0 is not wrapped at 72nd column
  • e138b89 must be in the format fixes #redmine_number - brief description
  • a0d1902 must be in the format fixes #redmine_number - brief description
  • 867e377 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@@ -29,7 +29,7 @@ def mod(manifest, params)
answers['foreman_proxy'] = {
'custom_repo' => true,
'http' => true,
'ssl_port' => '9090',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrations are executed only once and then it's stored that it was executed. That means you have to create new migrations. There's a helper script bin/create-migration

@peppos
Copy link
Author

peppos commented Dec 4, 2017

I have found this problem. When I install Katello and I want to use a cockpit plugin I have a conflit on a TCP port 9090. The 9090 port is used for communication with the Smart Proxy and also the cockpit. I have propose 9093 but another port is valid.

@peppos
Copy link
Author

peppos commented Dec 4, 2017

My target is: change the default port on answer file when I use the scenario katello.

@ekohl
Copy link
Member

ekohl commented Dec 5, 2017

The bot wants you to modify the commit message. It should be sufficient to squash it all in a single commit and have it include Fixes #21859 - .

@peppos
Copy link
Author

peppos commented Dec 7, 2017

Ok! sorry @ekohl

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 0edbce0 must be in the format fixes #redmine_number - brief description
  • commit message for 0edbce0 is not wrapped at 72nd column
  • e138b89 must be in the format fixes #redmine_number - brief description
  • a0d1902 must be in the format fixes #redmine_number - brief description
  • 867e377 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • commit message for b60cbad is not wrapped at 72nd column
  • commit message for 74d4dc3 is not wrapped at 72nd column
  • commit message for a8ea84d is not wrapped at 72nd column
  • commit message for c280837 is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

Change default ssl port because is not compatible with cockpit
Change default ssl port because is not compatible with cockpit
Change default ssl port because is not compatible with cockpit
Change default ssl port because is not compatible with cockpit
@ehelms
Copy link
Member

ehelms commented Dec 7, 2017 via email

@ekohl
Copy link
Member

ekohl commented Dec 7, 2017

I partly agree with @ehelms that changing it to another port is not worth the effort. If we could change our stack back to port 8443 to match vanilla foreman that would be an interesting option. We would need to take care of RHSM in that case. That is a big change though.

@peppos
Copy link
Author

peppos commented Dec 7, 2017

Yes is the big change. This is valid only if I install katello and not if I install Foreman. If I already use the cockpit in all my servers I must modify all cockpit port and all firewall rules. Alternatively is possible to add a specific option or add the entry in the help like "If you want use the cockpit modify this port" or add this issue in the official documentation. In the mean time I can propose to change the port on cockpit prj if you want.

@peppos
Copy link
Author

peppos commented Dec 7, 2017

I forgot, if I change the cockpit port I must modify the foreman_cockpit plugin for use a new port.

@ekohl
Copy link
Member

ekohl commented Dec 8, 2017

It's good to note that these are the defaults. You're still free to change the values in your installation by providing these as command line arguments to the installer. See --help or --full-help in case they're under advanced sections.

@peppos
Copy link
Author

peppos commented Dec 11, 2017

I understood that is a default value. But this default is not compatible with default cockpit plugin installation and this is not configurable via option in my installation command but only editing the file.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2018

While I appreciate that, it's simply too big of a change at this point to manage. A lot of our documentation, downstream usage and other integrations would need to be changed. When we do invest time into this, it'd make more sense to align it back with foreman to 8443. I recall @stbenjam having looked into that so maybe he can give his opinion on it.

@stbenjam
Copy link
Contributor

I recall @stbenjam having looked into that so maybe he can give his opinion on it.

I was only looking at getting rid of using 8443 on the Katello capsule as a reverse proxy. I think that would need to be done first before we consider moving the proxy port back to 8443 to align with Foreman.

@peppos
Copy link
Author

peppos commented Jan 15, 2018

Ok, if you want I can test it.

@ekohl
Copy link
Member

ekohl commented Jan 18, 2018

For now it'll need quite a bit of effort and it's not high on my agenda right now. Maybe @stbenjam could outline the needed steps for anyone who wants to work on this.

@stbenjam
Copy link
Contributor

For your own environment if you wanted to run the installer with --foreman-proxy-ssl-port=9093 I'd expect it to work - if you have SELinux permissive or add the appropriate rules to allow Rails to connect to 9093.

The best solution long term would for us to move to 8443, but it's in use by something else. That needs to get moved to 443, but there needs to be some ability for at least some period of time to support both ports - that's the problem with moving things. There are many many many client systems out there that connect to 8443 for the subscription-manager service, they need to get moved to 443 but we need to give people at least one release to do it, maybe two.

I started some work over here last year, but didn't get a chance to finish it.

@ehelms
Copy link
Member

ehelms commented May 24, 2018

@peppos I wanted to clarify something as I think about this. This only affects cockpit running on the actual Foreman server with Katello? That is to say, our choice of port currently does not break Cockpit on all the hosts being managed just simply viewing cockpit for the server itself?

@peppos
Copy link
Author

peppos commented May 25, 2018

@ehelms not only for cockpit on Foreman but for all cockpit, because the url is the same for all host. Only the hostname is a variable in the plugin code. From my point of view the are three ways, modify the port for all cockpit services on all servers or modify the foreman proxy port or modify the plugin code and assume that port is a variable.

@ehelms
Copy link
Member

ehelms commented Jun 1, 2018

I think option 3 has the most flexibility and would require the least amount of re-configuration in user environments. Further, that allows an organization to modify the cockpit ports across hosts if they have requirements around port usage.

zjhuntin pushed a commit to zjhuntin/katello-installer that referenced this pull request Oct 30, 2018
1. decrease the chunk size to be compatible with Pulp's expectations
2. suppress false-positive warnings from rest-client
3. log exceptions properly
@ekohl
Copy link
Member

ekohl commented Dec 14, 2018

This repository has been deprecated and merged into https://github.com/theforeman/foreman-installer (#731). If this is still relevant, please resubmit the PR there.

@ekohl ekohl closed this Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants