Skip to content
This repository has been archived by the owner on Oct 9, 2018. It is now read-only.

fixes #7445 and BZ1139894 - optionally utilize the RHSCL #42

Merged
merged 1 commit into from Sep 15, 2014

Conversation

mccun934
Copy link
Member

This will optionally create a local repo if the ISO contains
the RHSCL repository. This allows users to install without
a remote RHSCL repository

name=scl-local
baseurl=file://%s/RHSCL
enabled=1
gpgcheck=%s""" % (DEST_DIR, GPG_CHECK))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the above section to something like

"""
[scl-local]
name=scl-local
baseurl=file://%(baseurl)s/RHSCL
enabled=1
gpgcheck=%(gpgcheck)s""" % dict (baseurl = DEST_DIR, gpgcheck = GPG_CHECK))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also will be great if contents were in a separate string and added to write.

@parthaa
Copy link
Contributor

parthaa commented Sep 15, 2014

LGTM other wise. ACK

This will optionally create a local repo if the ISO contains
the RHSCL repository.  This allows users to install without
a remote RHSCL repository
mccun934 added a commit that referenced this pull request Sep 15, 2014
fixes #7445 and BZ1139894 - optionally utilize the RHSCL
@mccun934 mccun934 merged commit 3d169b4 into Katello:master Sep 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants