Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
845668 - removing console.log usage from js, which cause FF3.6 failures
Firefox 3.6 notoriously does not play nice with console.log.  In the case
of 845668, it caused the behavior of adding a system to a system
group to fail without any noticable errors.

The katello js had 3 instances of console.log actively included.  Since
each of those cases looks more to be there for 'debugging' purposes, I have
removed them.

If they are *really* needed, we can add them back with some protection
around them.  An example might be:

if ( typeof console !== "undefined" && console.error && console.warn ) {
  console.log(element.label);
}
  • Loading branch information
bbuckingham committed Aug 27, 2012
1 parent d2ac06a commit f905090
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions src/public/javascripts/content_search.js
Expand Up @@ -223,9 +223,6 @@ KT.content_search = function(paths_in){
else if (search_pages[search_params.content_type] ){
main_search(search_params);
}
else{
console.log(search_params);
}
},
main_search = function(search_params){
var options = {};
Expand Down
1 change: 0 additions & 1 deletion src/public/javascripts/system_groups.js
Expand Up @@ -323,7 +323,6 @@ KT.system_groups = (function(){
$.get(KT.routes.auto_complete_systems_path(), {term:string}, function(data){
var found = false;
$.each(data, function(index, element){
console.log(element.label);
if (element.label === string){
found = element.id;

Expand Down
1 change: 0 additions & 1 deletion src/public/javascripts/system_subscriptions.js
Expand Up @@ -60,7 +60,6 @@ $(document).ready(function() {
name : element.attr('name'),
data : element.data('options'),
onsuccess : function(result, status, xhr){
console.log(xhr.responseText);
element.select(xhr.responseText);
notices.checkNotices();
}
Expand Down

0 comments on commit f905090

Please sign in to comment.