886718 - allow better translation of one string #1594

Merged
merged 1 commit into from Feb 25, 2013

2 participants

@xsuchy

Original string has different translation depending on object_type.
I created several new strings with hardcoded object_type and
only left as variable in string "label".

This is quite ugly code, but I prefer it over ugly sentence as suggested
in:
https://bugzilla.redhat.com/show_bug.cgi?id=886718#c7
(even if it is grammatical correct).

@xsuchy xsuchy 886718 - allow better translation of one string
Original string has different translation depending on object_type.
I created several new strings with hardcoded object_type and
only left as variable in string "label".

This is quite ugly code, but I prefer it over ugly sentence as suggested
in:
https://bugzilla.redhat.com/show_bug.cgi?id=886718#c7
(even if it is grammatical correct).
63af5d0
@iNecas iNecas commented on the diff Feb 22, 2013
src/app/controllers/application_controller.rb
"automatically assigned. If you would like a different label, please delete the " +
- "%s and recreate it with the desired label.") % [object_type, new_object.label, object_type]
+ "#{object_type} and recreate it with the desired label."
@iNecas
Katello Project member
iNecas added a note Feb 22, 2013

We can't use #{object_type} style of interpolation here

@xsuchy
xsuchy added a note Feb 22, 2013

Why not?

@iNecas
Katello Project member
iNecas added a note Feb 23, 2013

Ok, i now see how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@iNecas
Katello Project member

ACK

@xsuchy xsuchy merged commit b2889df into Katello:master Feb 25, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment