Bastion: replacing tipsy with bootstrap 3 tooltips. #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,14 +63,14 @@ <h2 class="fl" translate>System {{ system.name }}</h2> | |||
| </nav> | |||
|
|
|||
| <div class="flash_hud" ng-show="saveSuccess"> | |||
| <a class="control clickable" title="Close" ng-click="saveSuccess = false"></a> | |||
| <a class="control clickable" tooltip="Close" ng-click="saveSuccess = false"></a> | |||
|
@ehelms updated. |
| @@ -5,7 +5,7 @@ | |||
| <a class="menu-item-link organization-name clickable" | |||
| ng-click="toggleVisibility()" | |||
| ng-class="{'active-item': visible}" | |||
| title="{{ currentOrganization.name }}"> | |||
| tooltip="{{ currentOrganization.name }}"> | |||
There was a problem hiding this comment.
This is a bit of a strange tooltip. I realize the title was there before, but unless we are cutting off the text via ellipsis (which I think we are avoiding) this looks off to me.
There was a problem hiding this comment.
Shall I just remove this one?
|
@ehelms updated again. |
|
What do you think about trying to do a helptip icon with tooltip instead of showing a greyed out remove button? |
|
@ehelms updated again. |
|
ACK |
waldenraines
pushed a commit
that referenced
this pull request
Nov 22, 2013
Bastion: replacing tipsy with bootstrap 3 tooltips.
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.