Activation key - show a list of registered systems #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new tab Systems with a list of systems registered with given activation key. Used keys are also shown on System detail page (Host & Guest Info section).
|
I don't think activation key belongs in the Host & Guest section; they are not related. I'd suggest perhaps in the System Events section, add an Activation Key entry. |
| @@ -0,0 +1,4 @@ | |||
| %tr{:class=> [cycle("", "alt"), 'parent']} | |||
| %td= link_to system.name, systems_url(:anchor => "panel=system_#{system.id}") | |||
There was a problem hiding this comment.
Can you verify that the user actually has read access to the system? system.readable? should be an easy way to check.
There was a problem hiding this comment.
I would still show it in the list if not readable, just don't link to it.
Otherwise do not show it as a link.
Conflicts: src/lib/navigation/content_management.rb
|
@jlsherrill @thomasmckay any other issues with this? |
|
ACK |
Pajk
added a commit
that referenced
this pull request
Aug 3, 2012
Activation key - show a list of registered systems
ehelms
pushed a commit
that referenced
this pull request
Apr 27, 2013
Activation key - show a list of registered systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activation key: Added link to Systems page into Systems Group pull down navigation. This new page contains a list of systems registered with given activation key.
System: Used keys are shown on System detail page (Host & Guest Info section).