Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5593, display authorized menu items post single page app. #4053

Merged
merged 1 commit into from May 8, 2014

Conversation

@waldenraines
Copy link
Member

commented May 6, 2014

http://projects.theforeman.org/issues/5593

Do not merge this until theforeman/foreman#1423 has been merged. The tests will not pass until then.

@ehelms

View changes

lib/katello/plugin.rb Outdated
:engine => Bastion::Engine
:url => 'lifecycle_environments',
:url_hash => {:controller => 'katello/api/v2/environments_controller',
:action => 'index'},

This comment has been minimized.

Copy link
@ehelms

ehelms May 6, 2014

Member

This is purely to protect that menu item based on the API accessibility?

This comment has been minimized.

Copy link
@waldenraines

waldenraines May 6, 2014

Author Member

Right, it won't display the menu item if you don't have perms to view the index. The :url property above is what the link ends up being as it takes precedence over the hash.

@waldenraines

This comment has been minimized.

Copy link
Member Author

commented May 7, 2014

@ehelms theforeman/foreman#1423 has been merged and this is now green.

@ehelms

View changes

lib/katello/plugin.rb Outdated
:bastion_page => 'lifecycle_environments'},
:engine => Bastion::Engine
:url => 'lifecycle_environments',
:url_hash => {:controller => 'katello/api/v2/environments_controller',

This comment has been minimized.

Copy link
@ehelms

ehelms May 7, 2014

Member

I think this needs to be just katello/api/v2/environments

This comment has been minimized.

Copy link
@waldenraines

waldenraines May 8, 2014

Author Member

Ah, you're right, thought I'd changed that, will update.

@waldenraines

This comment has been minimized.

Copy link
Member Author

commented May 8, 2014

@ehelms updated.

@ehelms

This comment has been minimized.

Copy link
Member

commented May 8, 2014

APJ

waldenraines added a commit that referenced this pull request May 8, 2014
Merge pull request #4053 from waldenraines/5593
Fixes #5593, display authorized menu items post single page app.

@waldenraines waldenraines merged commit fe48da2 into Katello:roles May 8, 2014

1 check passed

default Job result: SUCCESS
Details

@waldenraines waldenraines deleted the waldenraines:5593 branch May 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.