fixes #7162 / BZ 1102763 - capsule - treat task as failed if sync times times out #4595
Conversation
| module Actions | ||
| module Pulp | ||
| module Consumer | ||
| class AbstractSyncNodeTask < ::Actions::Pulp::AbstractAsyncTask |
There was a problem hiding this comment.
Any reason you chose to create another class to house this? Do you see it being used by other actions? (Versus just sticking it in the sync_node.rb class?)
There was a problem hiding this comment.
I initially added it to the sync node class; however, it wasn't getting invoked. Since I saw the other cases that extended this method used separate classes, I decided to be consistent w/ them. As for reusing it later, there is a possibility, if we find other cases where the pulp structure is similar; however, we'd want to change class name for clarity at that point.
bbuckingham
force-pushed
the
issue-7162
branch
from
289b265
to
14b32a9
Compare
|
[test] |
| if pulp_task[:result] && | ||
| pulp_task[:result][:details] && | ||
| pulp_task[:result][:details][:repository] && | ||
| pulp_task[:result][:details][:repository][:succeeded] == false |
There was a problem hiding this comment.
for me its pulp_task['result']['details']["node"]["succeeded"]
There was a problem hiding this comment.
@jlsherrill, As we found in irc discussion, pulp could return either:
pulp_task['result']['details']["node"]["succeeded"]
or
pulp_task['result']['details']["repository"]["succeeded"]
As a result, in order to have a generic check, I have updated the logic to use:
pulp_task['result']['succeeded']
bbuckingham
force-pushed
the
issue-7162
branch
from
14b32a9
to
f5438c8
Compare
|
APJ |
|
[test] |
…ync times out with capsule Without this change, when an error (such as timeout) occurs attempting to 'capsule content synchronize' an environment, the synchronize task is reported as successful. E.g. from cli, this might look like: hammer> capsule content synchronize --id 3 --environment-id 5 [.....................................................................] [100%] Task 6c80df66-af10-44aa-9eca-c96992148811: success With this change, if an error occurs that is reported back from pulp as succeeded=false, we'll treat this as an error (because it is). In this scenario, the cli might look like: hammer> capsule content synchronize --id 3 --environment-id 5 [.....................................................................] [100%] Task 2246bfb5-131f-4171-a7c3-6e16e3276ddd: warning
bbuckingham
force-pushed
the
issue-7162
branch
from
f5438c8
to
f778714
Compare
fixes #7162 / BZ 1102763 - capsule - treat task as failed if sync times times out
Without this change, when an error (such as timeout) occurs attempting to
'capsule content synchronize' an environment, the synchronize task is reported
as successful. E.g. from cli, this might look like:
hammer> capsule content synchronize --id 3 --environment-id 5
[.....................................................................] [100%]
Task 6c80df66-af10-44aa-9eca-c96992148811: success
With this change, if an error occurs that is reported back from pulp as
succeeded=false, we'll treat this as an error (because it is). In
this scenario, the cli might look like:
hammer> capsule content synchronize --id 3 --environment-id 5
[.......................... ] [50%]
Task 2246bfb5-131f-4171-a7c3-6e16e3276ddd: error