Fixes #7915 - copy uploaded files to shared tmp directory in plan phase #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APJ, tested on production install and it works great! |
|
Did some updates to make the tests passing, ready for re-review |
| @@ -10,6 +10,9 @@ | |||
| # have received a copy of GPLv2 along with this software; if not, see | |||
| # http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt. | |||
|
|
|||
| require 'fileutils' | |||
| require 'English' | |||
There was a problem hiding this comment.
@iNecas, curious, why is 'English' required?
There was a problem hiding this comment.
It's because of https://github.com/Katello/katello/pull/4736/files#diff-acda6ac6712e66fc9557b7631a8befbfR47 , $ERROR_INFO, that rubocop suggested over $!
|
ACK |
iNecas
added a commit
that referenced
this pull request
Oct 14, 2014
Fixes #7915 - copy uploaded files to shared tmp directory in plan phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running foreman-tasks service via systemd, it's process has isolated
/tmpdirectory. Copy the uploaded files to shared location in web serverprocess before getting to the dynflow executor so that it can read the data.