New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #8710 - created katello-debug sub-package #4970
Conversation
1a43af3
to
4e9c1f7
Compare
|
For now, you'll want to add it to |
| add_files "/var/log/audit/audit.log" | ||
| # Installer | ||
| add_files "/var/log/katello-installer/*" | ||
| add_files "/etc/katello-installer/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the installer break out, {/etc,/var/log}/capsule-installer and {/etc,/var/log}/sam-installer as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, amended.
|
Oh I figured out where the compose files are :-) Nice and handy. |
|
I was thinking about puppet-capsule and started actually the file, but I figured out it is unnecessary. Foreman-debug helper functions ignores files/dirs which does not exist. Therefore you can run |
4e9c1f7
to
dafc310
Compare
|
Ah, I meant to use You could also add it to capsule-installer, although I'd prefer it to be separate. |
|
if this is just for the capsule, any reason to not call it 'capsule-debug'? |
|
I can think of a few reasons why the prefix is better, it comes up in a search for |
|
And I believe it's for both, one debug package for capsule and katello. |
|
Yeah, it works for both. You run the same script on Server and Capusle and it gives reasonable results for both. Splitting is an overkill IMHO. |
|
Ah i see, l LGTM |
|
[test] |
| add_files "/etc/splice/*" | ||
| add_files "/etc/httpd/conf.d/splice.conf", | ||
| add_files "/etc/cron.d/spacewalk-sst-sync" | ||
| add_files "/etc/cron.d/splice-sst-sync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both 31-32?
With review of katello-debug plugin script, did a cleanup.
dafc310
to
b1b0ac6
Compare
|
Amended the three lines. |
|
Hello? |
|
Please when merging this also merge this one: https://github.com/Katello/puppet-capsule/pull/33/files Downstream BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1134109 Thanks |
|
[test] |
|
ACK from me, @stbenjam ? |
|
Yea ACK |
|
Thanks @lzap |
Refs #8710 - created katello-debug sub-package
With review of katello-debug plugin script, did a cleanup.
@jsherrill @ehelms can you guys give me assistance in changing composes,
building and pushing the subpackage change out?
I also want to make a change to the installer to install
katello-debugpackage on Capsules. What is the best way to do that @iNecas?
Thanks