Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #8710 - created katello-debug sub-package #4970

Merged
merged 1 commit into from Feb 18, 2015

Conversation

lzap
Copy link
Contributor

@lzap lzap commented Feb 3, 2015

With review of katello-debug plugin script, did a cleanup.

@jsherrill @ehelms can you guys give me assistance in changing composes,
building and pushing the subpackage change out?

I also want to make a change to the installer to install katello-debug
package on Capsules. What is the best way to do that @iNecas?

Thanks

@stbenjam
Copy link
Contributor

stbenjam commented Feb 3, 2015

For now, you'll want to add it to puppet-capsule... but in the future we need to have a katello-capsule package that requires this, had a restart script, and anything else capsule-specific.

add_files "/var/log/audit/audit.log"
# Installer
add_files "/var/log/katello-installer/*"
add_files "/etc/katello-installer/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the installer break out, {/etc,/var/log}/capsule-installer and {/etc,/var/log}/sam-installer as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, amended.

@lzap
Copy link
Contributor Author

lzap commented Feb 3, 2015

Oh I figured out where the compose files are :-) Nice and handy.

http://koji.katello.org/koji/taskinfo?taskID=218610

@lzap
Copy link
Contributor Author

lzap commented Feb 3, 2015

I was thinking about puppet-capsule and started actually the file, but I figured out it is unnecessary. Foreman-debug helper functions ignores files/dirs which does not exist. Therefore you can run katello-debug both on Server and Capsule and both return reasonable tarballs. I can split the file into two, but I think that is little bit over-complicated.

@stbenjam
Copy link
Contributor

stbenjam commented Feb 3, 2015

Ah, I meant to use puppet-capsule to install the package on the capsule because there's no dedicated package yet, unless you want to add one here to the katello.spec.

You could also add it to capsule-installer, although I'd prefer it to be separate.

@jlsherrill
Copy link
Member

if this is just for the capsule, any reason to not call it 'capsule-debug'?

@stbenjam
Copy link
Contributor

stbenjam commented Feb 4, 2015

I can think of a few reasons why the prefix is better, it comes up in a search for rpm -qa | grep katello, it will automatically work with katello-remove, etc.

@stbenjam
Copy link
Contributor

stbenjam commented Feb 4, 2015

And I believe it's for both, one debug package for capsule and katello.

@lzap
Copy link
Contributor Author

lzap commented Feb 5, 2015

Yeah, it works for both. You run the same script on Server and Capusle and it gives reasonable results for both. Splitting is an overkill IMHO.

@jlsherrill
Copy link
Member

Ah i see, l LGTM

@jlsherrill
Copy link
Member

[test]

add_files "/etc/splice/*"
add_files "/etc/httpd/conf.d/splice.conf",
add_files "/etc/cron.d/spacewalk-sst-sync"
add_files "/etc/cron.d/splice-sst-sync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both 31-32?

With review of katello-debug plugin script, did a cleanup.
@lzap
Copy link
Contributor Author

lzap commented Feb 12, 2015

Amended the three lines.

@lzap
Copy link
Contributor Author

lzap commented Feb 18, 2015

Hello?

@lzap
Copy link
Contributor Author

lzap commented Feb 18, 2015

Please when merging this also merge this one: https://github.com/Katello/puppet-capsule/pull/33/files

Downstream BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1134109

Thanks

@jlsherrill
Copy link
Member

[test]

@jlsherrill
Copy link
Member

ACK from me, @stbenjam ?

@stbenjam
Copy link
Contributor

Yea ACK

@jlsherrill
Copy link
Member

Thanks @lzap

jlsherrill added a commit that referenced this pull request Feb 18, 2015
Refs #8710 - created katello-debug sub-package
@jlsherrill jlsherrill merged commit 5fa799e into Katello:master Feb 18, 2015
@lzap lzap deleted the debug-capsule-split-8710 branch February 19, 2015 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants