845668 - removing console.log usage from js, which cause FF3.6 failures #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox 3.6 notoriously does not play nice with console.log. In the case
of 845668, it caused the behavior of adding a system to a system
group to fail without any noticable errors.
The katello js had 3 instances of console.log actively included. Since
each of those cases looks more to be there for 'debugging' purposes, I have
removed them.
If they are *really* needed, we can add them back with some protection
around them. An example might be:
if ( typeof console !== "undefined" && console.error && console.warn ) {
console.log(element.label);
}
mccun934
added a commit
that referenced
this pull request
Aug 27, 2012
845668 - removing console.log usage from js, which cause FF3.6 failures
mccun934
added a commit
that referenced
this pull request
Apr 27, 2013
845668 - removing console.log usage from js, which cause FF3.6 failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 3.6 notoriously does not play nice with console.log. In the case
of 845668, it caused the behavior of adding a system to a system
group to fail without any noticable errors.
The katello js had 3 instances of console.log actively included. Since
each of those cases looks more to be there for 'debugging' purposes, I have
removed them.
If they are really needed, we can add them back with some protection
around them. An example might be:
if ( typeof console !== "undefined" && console.error && console.warn ) {
console.log(element.label);
}