Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #10055 - Initial model bindings for OSTREE CRUD #5240

Merged
merged 1 commit into from Jun 11, 2015

Conversation

Projects
None yet
4 participants
@parthaa
Copy link
Member

commented May 20, 2015

No description provided.

@parthaa

This comment has been minimized.

Copy link
Member Author

commented May 21, 2015

[test]

:name,
:checksum_type,
:docker_upstream_name,
:ostree_branches => [])

This comment has been minimized.

Copy link
@daviddavis

daviddavis May 21, 2015

Member

Why did you break apart the array here? I think having two copies of the array is harder to maintain, no?

This comment has been minimized.

Copy link
@ehelms

ehelms May 21, 2015

Member

I have also never understood the style of dangling when its method calls, you wouldn't write a hash declaration that way, e.g.:

params.require(:repository).permit({:label => yo,
                                           :content_type => blah,
                                           :url => stuff,
                                           :gpg_key_id => foo,
                                           :docker_upstream_name => things,
                                           :ostree_branches => []})

vs.

params.require(:repository).permit(
  :label,
  :content_type,
  :url,
  :docker_upstream_name,
  :ostree_branches => []
)

/endstylerant

This comment has been minimized.

Copy link
@parthaa

parthaa May 21, 2015

Author Member

Why did you break apart the array here? I think having two copies of the array is harder to maintain, no?

I didn't realize I could have an array that looked like this
[:url, :gpg_key_id, :unprotected, :name, :checksum_type, :docker_upstream_name, :ostree_branches => []]
where its symbols and last arg being an Hash. Been corrected now. Thanks for pointing out

@parthaa parthaa force-pushed the parthaa:ostree-crud branch 2 times, most recently from 1f3d9f0 to 236c227 May 21, 2015

@daviddavis

This comment has been minimized.

Copy link
Member

commented May 22, 2015

[test]

@daviddavis

This comment has been minimized.

Copy link
Member

commented May 29, 2015

APJ

@parthaa parthaa force-pushed the parthaa:ostree-crud branch to 2819c39 Jun 10, 2015

parthaa added a commit that referenced this pull request Jun 11, 2015

Merge pull request #5240 from parthaa/ostree-crud
Refs #10055 - Initial model bindings for OSTREE CRUD

@parthaa parthaa merged commit b7a8b9c into Katello:ostree Jun 11, 2015

1 check passed

default Job result: SUCCESS
Details

@parthaa parthaa deleted the parthaa:ostree-crud branch Jun 11, 2015

parthaa added a commit to parthaa/katello that referenced this pull request Feb 12, 2016

Fixes #13585 - Adding Ostree functionality
Changes include

Fixes #10042 - Enable ostree repos in the CDN -
Katello#5455

Fixes #11611 - Copy over ostree branches on publish and promote -
Katello#5449

Ref #10040 - Minor fixes for the ostree repo create code -
Katello#5448

1) Added the missing auto_publish : true setting for OSTree repo
creation
2) Removed the nodes distributor for ostree since we are changing that
mechanism to a different model. (Nodes distributor is also not supported
for ostree content.)

Fixes #10066 - Support promoting ostree repos -
Katello#5447

Refs #10040 - Ostree branch change now updates pulp -
Katello#5431

Fixes #10063 - Allow publishing of ostree repos in content views -
Katello#5415

Fixes #11567 - Fix relative_path for ostree repos -
Katello#5442

Fixes #10040 - UI Bindings to CRUD rpm-ostree -
Katello#5394
Includes adding/updating/removing  branches

Fixes #10044 - UI to remove/add ostree repos to CVs -
Katello#5361
Fixes #10056 - Adding ostree sync -
Katello#5306
Refs #10062 - Allow users to add/remove ostree repos
-Katello#5337

Refs #10055 - Initial model bindings for OSTREE CRUD -
Katello#5240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.