Fixes #7162 - timeout capsule sync task #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def process_timeout | ||
| accept_timeout = Setting['content_action_accept_timeout'] | ||
| finish_timeout = Setting['content_action_finish_timeout'] |
There was a problem hiding this comment.
We may want to use a different timeout from the existing content_action_finish_timeout. My reasoning is that a system installing some packages should not take longer than an hour under most circumstances. The node sync hoewver probably will take longer to sync than an hour for most people on the initial sync. I think its fine to reuse the accept_timeout though.
dustints
force-pushed
the
timeout_cap_sync
branch
from
f131a90
to
68a0207
Compare
|
@jlsherrill updated with new timeout settings and scheduled timeout. |
dustints
force-pushed
the
timeout_cap_sync
branch
from
68a0207
to
f6405f2
Compare
|
ACK |
dustints
pushed a commit
that referenced
this pull request
Jun 9, 2015
Fixes #7162 - timeout capsule sync task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.