Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10056 - Adding ostree sync #5306

Merged
merged 1 commit into from Jul 14, 2015

Conversation

Projects
None yet
4 participants
@daviddavis
Copy link
Member

commented Jun 16, 2015

No description provided.

@daviddavis daviddavis changed the title [DO NOT REVIEW] Fixes #10056 - Adding ostree sync Fixes #10056 - Adding ostree sync Jun 24, 2015

@ehelms

View changes

app/lib/actions/pulp/repository/presenters/ostree_presenter.rb Outdated

def humanized_details
ret = []
ret << _("Cancelled.") if cancelled?

This comment has been minimized.

Copy link
@ehelms

ehelms Jun 29, 2015

Member

The other messages don't appear to end in a period

@ehelms

View changes

app/lib/actions/pulp/repository/presenters/ostree_presenter.rb Outdated
completion
else
0.01
end

This comment has been minimized.

Copy link
@ehelms

ehelms Jun 29, 2015

Member

You could potentially do:

def progress
  return 0.01 unless (details = task_progress_details)

  completion = 0.0
   ....
   ....
   completion
end
@ehelms

View changes

app/lib/actions/pulp/repository/presenters/ostree_presenter.rb Outdated
end

def current_step
task_progress_details.each do |step|

This comment has been minimized.

Copy link
@ehelms

ehelms Jun 29, 2015

Member

Could use find here?

@parthaa

View changes

app/lib/actions/pulp/repository/presenters/ostree_presenter.rb Outdated
module Pulp
module Repository
module Presenters
class OSTreePresenter < AbstractSyncPresenter

This comment has been minimized.

Copy link
@parthaa

parthaa Jul 8, 2015

Member

Have a feeling we are better off calling this OstreePresenter. I think foreman tasks has trouble picking this because of the mixed case. Check out how its used in https://github.com/Katello/katello/blob/ostree/app/models/katello/ostree_branch.rb#L2

@daviddavis

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2015

[test]

@parthaa

This comment has been minimized.

daviddavis added a commit that referenced this pull request Jul 14, 2015

Merge pull request #5306 from daviddavis/ostree-sync
Fixes #10056 - Adding ostree sync

@daviddavis daviddavis merged commit b940238 into Katello:ostree Jul 14, 2015

1 check passed

default Job result: SUCCESS
Details

parthaa added a commit to parthaa/katello that referenced this pull request Feb 12, 2016

Fixes #13585 - Adding Ostree functionality
Changes include

Fixes #10042 - Enable ostree repos in the CDN -
Katello#5455

Fixes #11611 - Copy over ostree branches on publish and promote -
Katello#5449

Ref #10040 - Minor fixes for the ostree repo create code -
Katello#5448

1) Added the missing auto_publish : true setting for OSTree repo
creation
2) Removed the nodes distributor for ostree since we are changing that
mechanism to a different model. (Nodes distributor is also not supported
for ostree content.)

Fixes #10066 - Support promoting ostree repos -
Katello#5447

Refs #10040 - Ostree branch change now updates pulp -
Katello#5431

Fixes #10063 - Allow publishing of ostree repos in content views -
Katello#5415

Fixes #11567 - Fix relative_path for ostree repos -
Katello#5442

Fixes #10040 - UI Bindings to CRUD rpm-ostree -
Katello#5394
Includes adding/updating/removing  branches

Fixes #10044 - UI to remove/add ostree repos to CVs -
Katello#5361
Fixes #10056 - Adding ostree sync -
Katello#5306
Refs #10062 - Allow users to add/remove ostree repos
-Katello#5337

Refs #10055 - Initial model bindings for OSTREE CRUD -
Katello#5240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.