New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #11447 - improve performance of product and repo index lists #5435

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Projects
None yet
3 participants
@jlsherrill
Member

jlsherrill commented Aug 21, 2015

alongside theforeman/foreman-tasks#129 this has shown to improve
a particular users product page load from ~10 minutes down to ~4 seconds

@ehelms

This comment has been minimized.

Show comment
Hide comment
@ehelms

ehelms Aug 24, 2015

Member

I see one case where it just says successfully synced repositories with no number attached in the UI

Member

ehelms commented Aug 24, 2015

I see one case where it just says successfully synced repositories with no number attached in the UI

@jlsherrill

This comment has been minimized.

Show comment
Hide comment
@jlsherrill

jlsherrill Aug 24, 2015

Member

@ehelms any idea on the circumstances to reproduce that?

Member

jlsherrill commented Aug 24, 2015

@ehelms any idea on the circumstances to reproduce that?

@jlsherrill

This comment has been minimized.

Show comment
Hide comment
@jlsherrill

jlsherrill Aug 24, 2015

Member

@ehelms i believe that is now fixed

Member

jlsherrill commented Aug 24, 2015

@ehelms i believe that is now fixed

@ehelms

This comment has been minimized.

Show comment
Hide comment
@ehelms

ehelms Aug 24, 2015

Member

In the screenshot, 2 of the products show sync data but no repository counts. Is that expected?

screenshot from 2015-08-24 13 01 33

Member

ehelms commented Aug 24, 2015

In the screenshot, 2 of the products show sync data but no repository counts. Is that expected?

screenshot from 2015-08-24 13 01 33

@jlsherrill

This comment has been minimized.

Show comment
Hide comment
@jlsherrill

jlsherrill Aug 24, 2015

Member

@ehelms could you provide the json for that product?

Member

jlsherrill commented Aug 24, 2015

@ehelms could you provide the json for that product?

@jlsherrill

This comment has been minimized.

Show comment
Hide comment
@jlsherrill

jlsherrill Aug 24, 2015

Member

a lot of this is exposing existing issues with the page :)

Member

jlsherrill commented Aug 24, 2015

a lot of this is exposing existing issues with the page :)

@ehelms

This comment has been minimized.

Show comment
Hide comment
@ehelms

ehelms Aug 24, 2015

Member

The JSON should be the same as I posted before -- however I am not seeing my previous comment with the JSON?

Member

ehelms commented Aug 24, 2015

The JSON should be the same as I posted before -- however I am not seeing my previous comment with the JSON?

@jlsherrill

This comment has been minimized.

Show comment
Hide comment
@jlsherrill
Member

jlsherrill commented Aug 24, 2015

@ehelms updated

fixes #11447 - improve performance of product and repo index lists
alongside theforeman/foreman-tasks#129 this has shown to improve
a particular users product page load from ~10 minutes down to ~4 seconds
@ehelms

This comment has been minimized.

Show comment
Hide comment
@ehelms

ehelms Aug 24, 2015

Member

APJ

Member

ehelms commented Aug 24, 2015

APJ

jlsherrill added a commit that referenced this pull request Aug 24, 2015

Merge pull request #5435 from jlsherrill/11447
fixes #11447 - improve performance of product and repo index lists

@jlsherrill jlsherrill merged commit bbcea20 into Katello:master Aug 24, 2015

1 check passed

default Job result: SUCCESS
Details

@jlsherrill jlsherrill deleted the jlsherrill:11447 branch Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment