Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10042 - Enable ostree repos in the CDN #5455

Merged
merged 1 commit into from Oct 22, 2015

Conversation

Projects
None yet
3 participants
@parthaa
Copy link
Member

commented Sep 1, 2015

No description provided.

@parthaa

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2015

@ehelms

View changes

app/models/katello/candlepin/content.rb Outdated
:unprotected => unprotected?,
:content_view_version => product.organization.library.default_content_view_version)
repository = Repository.new(
:environment => product.organization.library,

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 16, 2015

Member

Could we align this better?

repository = Repository.new(
  :environment => product.organization.library,
  ...
end

def validate!
return if katello_content_type == Repository::OSTREE_TYPE

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 16, 2015

Member

Should this return true (instead of nil) ?

This comment has been minimized.

Copy link
@parthaa

parthaa Sep 22, 2015

Author Member

This method is used as a "yell" rather than as a true false check

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 22, 2015

Member

It is returning 'nil', which is a 'falsy' value. So if you did ever write logic that checked validate! you would get a false if its an ostree, when it appears you want this to act as if it is valid.

This comment has been minimized.

Copy link
@parthaa

parthaa Sep 24, 2015

Author Member

point of a method ending with ! is that its return value is void..

look at the implementation of validate! in that file in general. I think it will make that clear .. https://github.com/parthaa/katello/blob/cdn/app/models/katello/candlepin/content.rb#L88

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 24, 2015

Member

There are all just terribly named, so we can leave it be.

@ehelms

View changes

app/models/katello/glue/pulp/repo.rb Outdated
:ssl_ca_cert => self.feed_ca,
:ssl_client_cert => self.feed_cert,
:ssl_client_key => self.feed_key
}

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 16, 2015

Member

Nitpick: fix identation

@ehelms

View changes

app/models/katello/candlepin/content.rb Outdated
if katello_content_type == Repository::OSTREE_TYPE
# TODO
# add a hard coded branch for now
# we will add pull all once the summary files functionality is available

This comment has been minimized.

Copy link
@ehelms

ehelms Sep 16, 2015

Member

Is there a redmine issue for this todo?

This comment has been minimized.

Copy link
@parthaa

parthaa Sep 22, 2015

Author Member

Is there a redmine issue for this todo?

http://projects.theforeman.org/issues/11926

@parthaa parthaa force-pushed the parthaa:cdn branch 2 times, most recently Sep 22, 2015

@parthaa parthaa force-pushed the parthaa:cdn branch to a517040 Sep 24, 2015

@ehelms

This comment has been minimized.

Copy link
Member

commented Oct 7, 2015

ACK

parthaa added a commit that referenced this pull request Oct 22, 2015

Merge pull request #5455 from parthaa/cdn
Fixes #10042 - Enable ostree repos in the CDN

@parthaa parthaa merged commit 3748092 into Katello:ostree Oct 22, 2015

1 check passed

default Job result: SUCCESS
Details

@parthaa parthaa deleted the parthaa:cdn branch Oct 22, 2015

parthaa added a commit to parthaa/katello that referenced this pull request Feb 12, 2016

Fixes #13585 - Adding Ostree functionality
Changes include

Fixes #10042 - Enable ostree repos in the CDN -
Katello#5455

Fixes #11611 - Copy over ostree branches on publish and promote -
Katello#5449

Ref #10040 - Minor fixes for the ostree repo create code -
Katello#5448

1) Added the missing auto_publish : true setting for OSTree repo
creation
2) Removed the nodes distributor for ostree since we are changing that
mechanism to a different model. (Nodes distributor is also not supported
for ostree content.)

Fixes #10066 - Support promoting ostree repos -
Katello#5447

Refs #10040 - Ostree branch change now updates pulp -
Katello#5431

Fixes #10063 - Allow publishing of ostree repos in content views -
Katello#5415

Fixes #11567 - Fix relative_path for ostree repos -
Katello#5442

Fixes #10040 - UI Bindings to CRUD rpm-ostree -
Katello#5394
Includes adding/updating/removing  branches

Fixes #10044 - UI to remove/add ostree repos to CVs -
Katello#5361
Fixes #10056 - Adding ostree sync -
Katello#5306
Refs #10062 - Allow users to add/remove ostree repos
-Katello#5337

Refs #10055 - Initial model bindings for OSTREE CRUD -
Katello#5240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.