Fixes #14043 - Fixes how product associations are made, to work with multiple organizations correctly.

[zjhuntin]

To reproduce:

1. Create two organizations and give them both manifests with overlapping products.
2. On one organization give it a product that has a subscription with many products (EG: I used Red Hat enterprise Linux 7 Server (Kickstart)).
3. In the other organization add products that are in the subscriptions products of the first organizations product. (EG: I enabled Linux Atomic Host RPMs and Oracle java RHEL server).
4. If the change has been applied then when you run hammer activation-key product-content --id [id of first organization's activation key] you should only see products enabled for the first organization. If it's not been applied you should see those and the products enabled in the second organization.

[ehelms]

@jlsherrill @thomasmckay could you double check this logic that it makes sense with respect to our modeling design vs Candlepin?

[thomasmckay]

@ehelms - give others a chance to review. commenting implies you need to ack too now

[ehelms]

No it doesn't, and I worked on this with Zach, which is why I am requesting
specific folks at a minimum.
On Mar 28, 2016 6:25 PM, "thomasmckay" notifications@github.com wrote:

@ehelms https://github.com/ehelms - give others a chance to review.
commenting implies you need to ack too now

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5919 (comment)

[jlsherrill]

Yes, this makes perfect sense, we should NEVER look up a product only by cp_id, as its not unique. By Cp_id + org_id should be unique.

[jlsherrill]

ACK Merging Thanks @zjhuntin !

[jlsherrill]

Actually i'll give @thomasmckay a chance to comment before merging

[thomasmckay]

ACK

[jlsherrill]

merging thanks @zjhuntin

[thomasmckay]

This did not fix the activation key product content. How was it tested?

[thomasmckay]

This fix did not fix the UI https://bugzilla.redhat.com/show_bug.cgi?id=1317679

[thomasmckay]

It also did not fix hammer. :) I will reopen redmine/bz.

[ehelms]

@thomasmckay did you test this with an existing setup or a fresh setup?

[thomasmckay]

I tested this on a dev install w/ latest katello/foreman git. UI shows no product content repos, while hammer shows the wrong repos.

[ehelms]

Sorry, let me rephrase, did you test this with existing data or start fresh? If you note the change is in the import method which means existing data is already fubared so you either need to reimport all data or start fresh.

[thomasmckay]

@ehelms - ACK! I refreshed manifest in org B (w/ breakpoints to confirm code is hit) and it looks good. I'll switch BZs back.