Fixes #15083: add puppet modules to the list of fenced pages. #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,12 +6,12 @@ describe('Factory: FencedPages', function() { | |||
| })); | |||
|
|
|||
| it("should list all the fenced pages", function () { | |||
| expect(FencedPages.list().length).toBe(10); | |||
| expect(FencedPages.list().length).toBe(11); | |||
There was a problem hiding this comment.
What is the purpose of this test? What kind of bugs are we expecting it to catch?
There was a problem hiding this comment.
Good question for @xprazak2 😉
I can improve this test if we want.
There was a problem hiding this comment.
I'd vote for removing this test and having the addPages test check that the length is incremented by 2 but I'll let it be your call.
|
ACK from me. |
Puppet Modules require an organization so add it to the list of fenced pages that require organizations. http://projects.theforeman.org/issues/15083
|
@daviddavis updated to remove test and fix check on |
|
👍 ACK x 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet Modules require an organization so add it to the list of fenced
pages that require organizations.
http://projects.theforeman.org/issues/15083