Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15824 - enabling a repository should fail on pulp error #6207

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

johnpmitsch
Copy link
Contributor

When enabling a repository, if there is a pulp error, the task will
be paused after creating the repository in the database, though
it is not created in pulp (since it errored). Moving this to create
in plan phase of Katello::Repository::Create ensures that the task
will stop and not complete on a pulp error, leaving the repository
disabled.

When enabling a repository, if there is a pulp error, the task will
be paused after creating the repository in the database, though
it is not created in pulp (since it errored). Moving this to create
in plan phase of Katello::Repository::Create ensures that the task
will stop and not complete on a pulp error, leaving the repository
disabled.
@johnpmitsch
Copy link
Contributor Author

To test:

  1. Don't install ostree
  2. Enable an ostree repo in red hat repositories page. (ping me if you need a manifest)
  3. ensure it fails with a pulp error The importer type ostree_web_importer does not exist
  4. ensure the enable repository task is in the 'stopped' state
  5. when you navigate back to the repository page, the ostree repo should be unchecked

@parthaa
Copy link
Contributor

parthaa commented Jul 29, 2016

ACK

@johnpmitsch johnpmitsch merged commit 236caa3 into Katello:master Aug 2, 2016
@johnpmitsch johnpmitsch deleted the enable_repo_15824 branch August 2, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants