fixes #16503 - composite view ui - newer component version exists #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following is an example of the UI with the change: |
| @@ -33,6 +33,13 @@ angular.module('Bastion.content-views').controller('ContentViewCompositeContentV | |||
| return deferred.promise; | |||
| }; | |||
|
|
|||
| $scope.newerVersionExists = function (contentViewVersion) { | |||
| var found = _.find(contentViewVersion['content_view']['content_view_version_ids'], function(num) { | |||
There was a problem hiding this comment.
With incremental update, the idea of a 'newer' version is somewhat muddled. Is it by version #? or just last published?
I would think it'd be by version number (i.e. 3.0 is newer than 2.2) even if the greater number was published before the lesser numbered version.
There was a problem hiding this comment.
Good point. It is actually using the database id, which implies the most recent version published. In the example above, that would mean 2.2 is newer than 3.0.
bbuckingham
force-pushed
the
issue-16503
branch
from
633cca0
to
f817bbc
Compare
Update the composite content view UI to let the user know if a newer version of a component content view exists.
bbuckingham
force-pushed
the
issue-16503
branch
from
f817bbc
to
5782bcf
Compare
|
@jlsherrill, updated the PR to base latest off of major version. Below is an updated screenshot for reference:
|
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the composite content view UI to let the user know
if a newer version of a component content view exists.