fixes #16265 - cv repos - indicate 'not synced' #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsherrill
reviewed
Sep 19, 2016
| @@ -112,14 +115,14 @@ <h3 translate> | |||
| <span ng-hide="repository.url" translate>N/A</span> | |||
| </td> | |||
| <td bst-table-cell> | |||
| <div ng-if="repository.content_counts.rpm && repository.content_counts.rpm > 0"> | |||
| <div> | |||
There was a problem hiding this comment.
whats the reason for removing this logic (and the one below)?
There was a problem hiding this comment.
@jlsherrill, Part of the user's request was to show 0 Packages 0 Errata. The UI does the same on product repositories list.
There was a problem hiding this comment.
Ah, since these are all yum repos i guess that is okay.
johnpmitsch
reviewed
Sep 20, 2016
There was a problem hiding this comment.
I am seeing "Not Synced N/A" on an unsynced repo http://www.clipular.com/c/6232312471879680.png?k=eG6t923Rl1LAW6yhVxLiyUQvPg8
I think it would look better if it just said "Not Synced"
jlsherrill
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
Minor change to the content view repositories UI based on user feedback to show 'Not Synced' and empty counts, when a repository has not yet been synced.
bbuckingham
force-pushed
the
issue-16265
branch
from
54f2175
to
25d6f29
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@johnpmitsch, Updated |
|
ACK |
|
Thanks @johnpmitsch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to the content view repositories UI based
on user feedback to show 'Not Synced' and empty counts,
when a repository has not yet been synced.