Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16134 - Support fqdn and override fact for host name #6328

Merged
merged 1 commit into from Oct 5, 2016
Merged

Fixes #16134 - Support fqdn and override fact for host name #6328

merged 1 commit into from Oct 5, 2016

Conversation

jlsherrill
Copy link
Member

@jlsherrill jlsherrill commented Sep 19, 2016 •
edited

TODO:

  • - write tests

@jlsherrill jlsherrill mentioned this pull request Sep 19, 2016
Merged
@jlsherrill
Copy link
Member Author

For testing, i'd start by reading the issue description, and then read theforeman/puppet-certs#100
that should give you a decent understanding of the issue.

and you'll also need to know about and pull in the most recent katello-agent from nightly that has this PR:
Katello/katello-host-tools#37

Let me know if there are any questions

@bbuckingham
Copy link
Member

ACK

@jlsherrill jlsherrill merged commit dc9787b into Katello:master Oct 5, 2016
@jlsherrill jlsherrill deleted the 16134 branch October 5, 2016 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@jlsherrill @bbuckingham @theforeman-bot