Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6757 - composite view to allow duplicate repos #6339

Merged
merged 1 commit into from Sep 28, 2016

Conversation

@bbuckingham
Copy link
Member

commented Sep 22, 2016

This commit removes the restriction that component content views
added to a composite content view are not allowed to contain
the same source repository. This is to handle the case where
the user is managing multiple instances of the repos with different
views/purposes and want to combine them through composites.

With this, when publishing a composite content view, if there are
N instances of the same repository, the version published for
the composite will only have 1 repository that combines them
all.

This change in behavior also affects incremental update as it
needs to ensure that that single repository is still a combination
of all versions on the composite (e.g. from new incremental versions
as well as the prior published versions).

fixes #6757 - composite view to allow duplicate repos
This commit removes the restriction that component content views
added to a composite content view are not allowed to contain
the same source repository.  This is to handle the case where
the user is managing multiple instances of the repos with different
views/purposes and want to combine them through composites.

With this, when publishing a composite content view, if there are
N instances of the same repository, the version published for
the composite will only have 1 repository that combines them
all.

This change in behavior also affects incremental update as it
needs to ensure that that single repository is still a combination
of all versions on the composite (e.g. from new incremental versions
as well as the prior published versions).
@jlsherrill

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

ACK

@bbuckingham bbuckingham merged commit bcafa5f into Katello:master Sep 28, 2016

2 checks passed

default Job result: SUCCESS
Details
hound No violations found. Woof!

@bbuckingham bbuckingham deleted the bbuckingham:issue-6757 branch Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.