Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #18634 - set Nutupane controllerName #6623

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
4 participants
@thomasmckay
Copy link
Member

commented Feb 23, 2017

The controllerName is required for bookmark searches

@mention-bot

This comment has been minimized.

Copy link

commented Feb 23, 2017

@thomasmckay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @waldenraines, @ehelms and @jlsherrill to be potential reviewers.

@waldenraines

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

@thomasmckay I don't know much about bookmark searches are there any changes to the API that are needed to support bookmarked search? @cfouant?

@thomasmckay

This comment has been minimized.

Copy link
Member Author

commented Feb 23, 2017

As long as the controllerName is set then the bookmark searches all work

@waldenraines

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

Doesn't this also address http://projects.theforeman.org/issues/18577?

Seems like that should maybe be marked as a duplicate.

@waldenraines

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

As long as the controllerName is set then the bookmark searches all work

Ah okay, they worked for the ones I tested but wasn't sure if there were some lower level changes needed.

@thomasmckay thomasmckay merged commit 4186110 into Katello:master Feb 24, 2017

2 checks passed

default Job result: SUCCESS
Details
hound No violations found. Woof!

@thomasmckay thomasmckay deleted the thomasmckay:18634-bookmarks branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.