Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20138 - fix host pkgs api #6845

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
4 participants
@jlsherrill
Copy link
Member

commented Jun 29, 2017

uniq is not needed here, as the scoped_search method handles this
already

Fixes #20138 - fix host pkgs api
uniq is not needed here, as the scoped_search method handles this
already
@mention-bot

This comment has been minimized.

Copy link

commented Jun 29, 2017

@jlsherrill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @waldenraines, @dLobatog and @ehelms to be potential reviewers.

@theforeman-bot

This comment has been minimized.

Copy link

commented Jun 29, 2017

Issues: #20138

@beav

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

whoops, didn't spot this til now, sorry.

The PR looks fine, but I'm not sure how query was becoming an array in the first place. Was the .uniq making it execute and then pass in the results instead of the query?

@jlsherrill

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2017

@beav that's exactly the case:

> Host.first.installed_packages.uniq.class
=> Array
@beav

This comment has been minimized.

Copy link
Member

commented Jul 5, 2017

ahhh!!

ack

@jlsherrill jlsherrill merged commit 7a73597 into Katello:master Jul 6, 2017

3 checks passed

default Job result: SUCCESS
Details
hound No violations found. Woof!
prprocessor Commit message style is correct
Details

@jlsherrill jlsherrill deleted the jlsherrill:20138 branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.