Katello 3.5.1 cherry picks #7173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e95b949)
(cherry picked from commit 9e9b39d)
also, i reogrdganized how repository glue tests are run so that the entire set does not have to be re-recorded just to add a new test. Now you can use the 'new_episodes' recording option' (cherry picked from commit d068817)
This commit addresses a bug where the docker tag name was not gettign autocompleted when requested from the UI. The Table referenced in the autocomplete did not point DockerMetaTag and instead pointed to DockerTag breaking this. (cherry picked from commit e77c2e6)
For some reason ProxyAPI::Pulp and ProxyAPI::PulpNode are not available to katello/SmartProxyExtensions, which causes a ResourceNotFound error when refreshing the proxy. Fix seems to be as simple as requiring proxy_api/pulp. (cherry picked from commit a89c0bb)
houndci-bot
reviewed
Jan 25, 2018
| end | ||
| end | ||
|
|
||
| #rubocop:disable Style/MixinUsage https://github.com/bbatsov/rubocop/issues/4885 |
There was a problem hiding this comment.
Unnecessary disabling of Style/MixinUsage.
(cherry picked from commit 3bf503c)
(cherry picked from commit ed0019a)
We refer to pools as subscriptions, so the subscription_id search should really be searching pools. To test this attach a sub to an activation key, go to that sub's details and click on the number next to "Activation Keys" in the Associations box. (cherry picked from commit 8c10553)
The product repository links were incorrectly changed after the switch to nutupane. This commit fixes the generation of the links. http://projects.theforeman.org/issues/21788 (cherry picked from commit 1bca4e4)
The "guests of <hypervisor>" link was broken because we changed the subscription API to no longer return hosts. This commit will grab the "requires_host" value from candlepin and adds that to a new field on the pools table, "hypervisor_id". This can then be referenced by UI, which will display the associated hypervisor. To test you will need to register a VDC subscription and a hypervisor running virt-who w/ guests. (cherry picked from commit c0d72eb)
|
[test rails-5] |
1 similar comment
|
[test rails-5] |
|
@akofink Ok, I think this ran for real now |
theforeman-bot
added
Waiting on contributor
Needs testing
and removed
Waiting on contributor
labels
|
I had to re-record a VCR cassette. |
This commit tries to speed up the publishing of content views via Errata filters by using Katello Database instead of requesting that information from pulp especially while planning. (cherry picked from commit 6c54a7f)
Currently the Content View and Lifecycle Environment are fields of a Content Facet. These fields have a NOT-NULL constraint, so they are validated on every host. This means that if I'm trying to create a CentOS, or Debian host, it will ask for a Content View and Lifecycle - which I may not want for hosts that don't use subscription-manager. In fact for the CentOS case, it's harmful: having a Content View for a CentOS host changes the @mediapath variable (the parameter sent to --url in the kickstart) to point to Pulp, which means you're pointing to Red Hat and installing Red Hat instead of CentOS (unless you've synced CentOS). (cherry picked from commit 405a1bc)
The Remote Execution User needs just view_hosts (side by side to execute_job_invocation) permission and there is no reason at all to use edit_hosts permission for this purposes in Katello. This way, the `Remote Execution User` role will work correctly for Katello use-cases as well, which was not the case, when using `edit_hosts` permission. (cherry picked from commit f7340d4)
This stop sending static and session Tracer types to RemoteEx. If a Trace is static, then the machine needs restarting. (cherry picked from commit fb68d6a)
(cherry picked from commit 7d166b1)
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
|
s/FactoryBot/FactoryGirl/ in 6c54a7f |
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
|
@ehelms rails-5 build passed |
|
[test default] |
1 similar comment
|
[test default] |
|
@akofink The default test is running properly now and throwing a real rubocop error. Up to you how you want to handle it. |
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
|
I disabled the MethodLength cop for that method. |
|
[test default] |
|
[test default] |
2 similar comments
|
[test default] |
|
[test default] |
ehelms
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.